From 429b573d46dd63681b69a3833c217ab8be361cb2 Mon Sep 17 00:00:00 2001 From: Michael Roy Date: Mon, 2 Jun 2025 09:51:12 -0300 Subject: [PATCH] Update utils.py Fix CodeQL alerts #1 and #2: Secure exception handling in get_sentry and get_quiz 33,115 --- backend/api_app/utils.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/backend/api_app/utils.py b/backend/api_app/utils.py index 3bc23ba..7bec286 100644 --- a/backend/api_app/utils.py +++ b/backend/api_app/utils.py @@ -28,9 +28,9 @@ def get_sentry(): response.raise_for_status() data = response.json() return Response(data, status=HTTP_200_OK) - except ValidationError as e: - print(e) - return Response(e, status=HTTP_400_BAD_REQUEST) + except (requests.RequestException, json.JSONDecodeError) as e: + logger.error(f"Error in get_sentry: {str(e)}", exc_info=True) + return Response({"error": "Failed to fetch Sentry data"}, status=HTTP_400_BAD_REQUEST) @@ -110,9 +110,9 @@ def get_quiz(): print(data) return Response(data, status=HTTP_201_CREATED) - except ValidationError as e: - print(e) - return Response(e, status=HTTP_400_BAD_REQUEST) + except (json.JSONDecodeError, openai.OpenAIError) as e: + logger.error(f"Error in get_quiz: {str(e)}", exc_info=True) + return Response({"error": "Failed to generate quiz"}, status=HTTP_400_BAD_REQUEST) # ask_question()